move coverage to test_nightly #304
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as coverage doesnt depend on dependencies and test_latest takes forever Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
move_coverage_to_test_nightly
branch
from
c24d0cd
to
3b1c61d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rolling #304 +/- ##
============================================
- Coverage 77.35% 61.40% -15.95%
============================================
Files 25 25
Lines 627 627
Branches 66 66
============================================
- Hits 485 385 -100
- Misses 121 228 +107
+ Partials 21 14 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
for some reason I have the same odd behavior locally:
While test_generate policy passes it doesnt appear in coverage results. Stalling this for now |
mikaelarguedas
force-pushed
the
move_coverage_to_test_nightly
branch
from
3b1c61d
to
1eeb328
Compare
Signed-off-by: Mikael Arguedas <[email protected]> adding to build for completeness but 0 impact on current issue Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
move_coverage_to_test_nightly
branch
from
1eeb328
to
ab20661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as coverage doesnt depend on dependencies and test_latest takes forever